Fix GH-20070: Return type violation in imagefilter when an invalid filter is provided #20071
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… filter is provided
devnexen
approved these changes
Oct 5, 2025
santysisi
reviewed
Oct 8, 2025
Comment on lines
+9
to
+16
| try { | ||
| var_dump(imagefilter($image, -1)); | ||
| } catch (Throwable $e) { | ||
| echo $e::class, ': ', $e->getMessage(), "\n"; | ||
| } | ||
| ?> | ||
| --EXPECT-- | ||
| ValueError: imagefilter(): Argument #2 ($filter) must be one of the IMG_FILTER_* filter constants |
There was a problem hiding this comment.
Hi, thanks a lot for the fix! I just have two suggestions:
- I think we can remove the
var_dumpas it's not necessary. - I believe the current test only checks that the value isn't less than the minimum allowed filter, but it doesn't test that it isn't greater than the maximum allowed filter. The fix should address that, so it might be worth adding a test for that case as well.
Thanks again for the fix!
Suggested change
| try { | |
| var_dump(imagefilter($image, -1)); | |
| } catch (Throwable $e) { | |
| echo $e::class, ': ', $e->getMessage(), "\n"; | |
| } | |
| ?> | |
| --EXPECT-- | |
| ValueError: imagefilter(): Argument #2 ($filter) must be one of the IMG_FILTER_* filter constants | |
| try { | |
| imagefilter($image, -1); | |
| } catch (Throwable $e) { | |
| echo $e::class, ': ', $e->getMessage(), "\n"; | |
| } | |
| try { | |
| imagefilter($image, 999); | |
| } catch (Throwable $e) { | |
| echo $e::class, ': ', $e->getMessage(), "\n"; | |
| } | |
| ?> | |
| --EXPECT-- | |
| ValueError: imagefilter(): Argument #2 ($filter) must be one of the IMG_FILTER_* filter constants | |
| ValueError: imagefilter(): Argument #2 ($filter) must be one of the IMG_FILTER_* filter constants |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.